fix(cli): remove prompt for immutable parameters on start and restart #9173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnstcn
approved these changes
Aug 18, 2023
mafredri
approved these changes
Aug 18, 2023
| tvp.Required || | ||
| (action == WorkspaceCreate && tvp.Required) || | ||
| (action == WorkspaceCreate && !tvp.Ephemeral) || | ||
| (action == WorkspaceUpdate && tvp.Required) || |
There was a problem hiding this comment.
Do we need something like && (tvp.Ephemeral || tvp.Mutable) here?
There was a problem hiding this comment.
tvp.Ephemeral is included in tvp.Ephemeral && pr.promptBuildOptions
Regarding tvp.Mutable, it depends on the action:
WorkspaceCreate: does not matter, we ask for every parameter*WorkspaceUpdate: skip immutables unless they are used for the first timeWorkspaceStartandWorkspaceRestart: skip immutables
*- we need to check also conditions for ephemerals
BTW if you spot any weird parameter condition, please let me know. I will adjust the logic and embrace with unit tests.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #9171