Skip to content

fix: add workspace_proxy type to auditlog friendly strings #9194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 21, 2023

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented Aug 18, 2023

Closes: #8833

Screenshot from 2023-08-18 12-26-48

I am going to check if I can unit test this. Won't be trivial because of Go and enums... but will be another PR. Let's just get this in.

@Emyrk Emyrk requested a review from sreya August 18, 2023 17:29
@Emyrk Emyrk enabled auto-merge (squash) August 18, 2023 17:29
@Emyrk Emyrk disabled auto-merge August 18, 2023 17:58
Copy link
Collaborator

@sreya sreya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@Emyrk Emyrk merged commit b2ca3eb into main Aug 21, 2023
@Emyrk Emyrk deleted the stevenmasley/unknown_audit_log branch August 21, 2023 15:53
@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

workspace proxies are returned as 'unknown' in the audit logs
2 participants