fix: disable setup page once setup has been completed #9198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the tests are broken locally right now, and debugging this through CI is rough 💀 |
| // If we've already completed setup, navigate to the login page | ||
| if ( | ||
| !authState.matches("loadingInitialAuthData") && | ||
| !authState.matches("configuringTheFirstUser") |
There was a problem hiding this comment.
Nit: Maybe we could do:
const isSetupComple = !authState.matches("loadingInitialAuthData") && !authState.matches("configuringTheFirstUser")
BrunoQuaresma
approved these changes
Aug 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9157
Setup will fail if a first user has been configured, and we already have this state on the client, so we should just use it to navigate you away