Skip to content

fix(site): fix ports update #9221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 21, 2023
Merged

fix(site): fix ports update #9221

merged 2 commits into from
Aug 21, 2023

Conversation

BrunoQuaresma
Copy link
Collaborator

  • Only fetches the port if the agent is connected
  • Update the ports every 5 seconds

Fix #9135

@BrunoQuaresma BrunoQuaresma self-assigned this Aug 21, 2023
@BrunoQuaresma BrunoQuaresma requested a review from bpmct August 21, 2023 13:41
cdr-bot[bot]
cdr-bot bot approved these changes Aug 21, 2023
View reviewed changes
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@BrunoQuaresma BrunoQuaresma merged commit f6e0206 into main Aug 21, 2023
@BrunoQuaresma BrunoQuaresma deleted the bq/fix-ports-update branch August 21, 2023 17:33
@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cdr-bot cdr-bot[bot] cdr-bot[bot] approved these changes

@bpmct bpmct Awaiting requested review from bpmct

Assignees

@BrunoQuaresma BrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

You must refresh the page to see the latest ports in "port forward" dialog
1 participant
@BrunoQuaresma