feat(site): add descriptions for each auth method to the selection menu #9252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "password", | ||
| form.values.login_type === "password" | ||
| ? "" | ||
| : "No password required for this login type", |
There was a problem hiding this comment.
If the password is not required, why not hide this field?
There was a problem hiding this comment.
jitter, mostly. on some level, seeing another field after the auth method prepares the user for "there is another potential step" even if it's disabled. if it's entirely hidden, they might just jump straight to the submit button.
There was a problem hiding this comment.
Nit: I would do this a bit differently.
Maybe we should make the authMethods required and make the parent display the loading state if it is not loaded since this field is required. So we could do something like:
const availableMethods = authMethods.filter(method => method.enabled).concat("none")
<TextField>
{availableMethods.map(method => {
const language = authMethodLanguage[method.id]
return (
<MenuItem key={value} id={"item-" + value} value={value}>
<Stack spacing={0} maxWidth={400}>
{language.displayName}
<span className={styles.labelDescription}>
{language.description}
</span>
</Stack>
</MenuItem>
)
})}
</TextField>
BrunoQuaresma
approved these changes
Aug 23, 2023
|
that's probably nicer than doing the weird not-quite-a-component stuff. I'll do a quick refactor. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly motivated by the fact that just saying "None" was really cryptic and confusing.