chore: add a base directory for TurboSnap #9258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BrunoQuaresma I did not realize the project was using Vite and TurboSnap won't work without the |
|
@BrunoQuaresma |
BrunoQuaresma
approved these changes
Aug 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need the
storybookBaseDirto tell TurboSnap that the .storybook directory and commands are in a sub-directory.workingDironly works for defining the current working directory.I also did not realize that this repository was using the Vite builder.
Vite requires a plugin to work with TurboSnap.
It was created by one of the Core maintainers of Storybook, Ian.
Here is an example project of it working.
https://github.com/chromaui/vite-project