Skip to content

fix: rewrite onlyDataResources #9263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 23, 2023
Merged

fix: rewrite onlyDataResources #9263

merged 3 commits into from
Aug 23, 2023

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented Aug 23, 2023

Fixes: #9260

This PR refactors the original implementation of onlyDataResources. It seems that it had a bug causing resources to be added multiple times.

@mtojek mtojek self-assigned this Aug 23, 2023
@mtojek mtojek marked this pull request as ready for review August 23, 2023 09:29
@mtojek mtojek requested review from johnstcn and ammario August 23, 2023 09:29
@mtojek mtojek enabled auto-merge (squash) August 23, 2023 10:10
@mtojek mtojek merged commit e6d90bd into main Aug 23, 2023
@mtojek mtojek deleted the fix-only-data-resources branch August 23, 2023 10:17
@github-actions github-actions bot locked and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error with 2.1.1 when planning workspace: coder_parameter names must be unique
2 participants