Skip to content

fix(cli): do not ask for immutables on update #9266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 23, 2023
Merged

fix(cli): do not ask for immutables on update #9266

merged 1 commit into from
Aug 23, 2023

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented Aug 23, 2023 •
edited
Loading

Fixes: #9171

This PR adjusts the logic of CLI ParameterResolver - CLI should not prompt for immutable parameters on standard update.

@mtojek mtojek self-assigned this Aug 23, 2023
@mtojek mtojek requested a review from mafredri August 23, 2023 10:34
@mtojek mtojek marked this pull request as ready for review August 23, 2023 10:34
mafredri
mafredri approved these changes Aug 23, 2023
View reviewed changes
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@mtojek mtojek merged commit a3d3126 into main Aug 23, 2023
@mtojek mtojek deleted the 9171-fix-port branch August 23, 2023 10:46
@github-actions github-actions bot locked and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mafredri mafredri mafredri approved these changes

Assignees

@mtojek mtojek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Coder CLI asking for input on immutable parameters, resulting in start/restart from CLI being broken
2 participants
@mtojek @mafredri