Skip to content

refactor(site): remove as many 100vh units as possible #9272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 24, 2023
Merged

refactor(site): remove as many 100vh units as possible #9272

merged 8 commits into from
Aug 24, 2023

Conversation

BrunoQuaresma
Copy link
Collaborator

100vh units can make things hard to work when dealing with flex layouts.

@BrunoQuaresma BrunoQuaresma requested a review from aslilac August 23, 2023 14:02
@BrunoQuaresma BrunoQuaresma self-assigned this Aug 23, 2023
cdr-bot[bot]
cdr-bot bot previously approved these changes Aug 23, 2023
View reviewed changes
Copy link

@cdr-bot cdr-bot bot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is no longer a hotfix.

  • ✅ Base is main
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ❌ Less than 100 lines

@BrunoQuaresma BrunoQuaresma changed the title refactor(site): remove 100vh units as possible refactor(site): remove as many 100vh units as possible Aug 23, 2023
aslilac
aslilac approved these changes Aug 23, 2023
View reviewed changes
Copy link
Member

@aslilac aslilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idk why but 100% makes me nervous these days...but I'm also not used to having Chromatic around, which seems to have our back for things like this, so let's try it!

@cdr-bot cdr-bot bot dismissed their stale review August 23, 2023 18:44

This PR is no longer a hotfix.

@BrunoQuaresma @aslilac
Update site/src/pages/TemplatePage/TemplateEmbedPage/TemplateEmbedPag…
b7aee6c 
…e.tsx

Co-authored-by: Kayla Washburn <mckayla@hey.com>
cdr-bot[bot]
cdr-bot bot previously approved these changes Aug 23, 2023
View reviewed changes
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@cdr-bot cdr-bot bot dismissed their stale review August 23, 2023 19:52

This PR is no longer a hotfix.

@BrunoQuaresma BrunoQuaresma merged commit 14aa1af into main Aug 24, 2023
@BrunoQuaresma BrunoQuaresma deleted the bq/refactor-layout branch August 24, 2023 12:25
@github-actions github-actions bot locked and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aslilac aslilac aslilac approved these changes

@cdr-bot cdr-bot[bot] cdr-bot[bot] left review comments

Assignees

@BrunoQuaresma BrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BrunoQuaresma @aslilac