Skip to content

ci: Improve peer logging to help identify race #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 30, 2022
Merged

ci: Improve peer logging to help identify race #93

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
40d204f
ci: Improve peer logging to help identify race
kylecarbs Jan 30, 2022
8343404
Remove mutex locks
kylecarbs Jan 30, 2022
f4c9dc2
Add hash to write
kylecarbs Jan 30, 2022
f655897
Improve comment
kylecarbs Jan 30, 2022
0a9ff49
Merge branch 'main' into peerdebug
kylecarbs Jan 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove mutex locks
  • Loading branch information
@kylecarbs
kylecarbs committed Jan 30, 2022
commit 83434046d84d3d9147e0cd64a0a78cd45386987c
4 changes: 0 additions & 4 deletions peer/conn.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,8 +142,6 @@ type Conn struct {
func (c *Conn) init() error {
c.rtc.OnNegotiationNeeded(c.negotiate)
c.rtc.OnICEConnectionStateChange(func(iceConnectionState webrtc.ICEConnectionState) {
c.closeMutex.Lock()
defer c.closeMutex.Unlock()
if c.isClosed() {
return
}
Expand All @@ -152,8 +150,6 @@ func (c *Conn) init() error {
slog.F("state", iceConnectionState))
})
c.rtc.OnICEGatheringStateChange(func(iceGatherState webrtc.ICEGathererState) {
c.closeMutex.Lock()
defer c.closeMutex.Unlock()
if c.isClosed() {
return
}
Expand Down