Skip to content

fix(site): only show workspace actions if user has permission #9303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

BrunoQuaresma
Copy link
Collaborator

Fix #9175

Screen Shot 2023-08-24 at 10 34 35

@BrunoQuaresma BrunoQuaresma self-assigned this Aug 24, 2023
@matifali
Copy link
Member

matifali commented Aug 24, 2023

Where can they see the build logs? I mean historical build logs of this workspace. Previous stars/stops, etc. @bpmct This was one of the reasons to keep access to another user's workspace. Right?

@BrunoQuaresma
Copy link
Collaborator Author

@matifali
Screen Shot 2023-08-24 at 10 34 35

@matifali
Copy link
Member

@matifali
Screen Shot 2023-08-24 at 10 34 35

Why I couldn't see. Thanks @BrunoQuaresma

Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BrunoQuaresma BrunoQuaresma merged commit 67c8635 into main Aug 24, 2023
@BrunoQuaresma BrunoQuaresma deleted the bq/fix-permission-workspace branch August 24, 2023 14:29
@github-actions github-actions bot locked and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve UX for template admin when viewing users' workspaces
2 participants