Skip to content

test(site): e2e: restart workspace with ephemeral parameters #9304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 25, 2023
Merged

test(site): e2e: restart workspace with ephemeral parameters #9304

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
47bbc4d
Restart ephemeral parameters
mtojek Aug 24, 2023
055d65f
Merge branch 'main' into 8789-ephemeral
mtojek Aug 25, 2023
0b8d6d8
start workspace with ephemerals
mtojek Aug 25, 2023
ca7feaa
refactor
mtojek Aug 25, 2023
0ddbac3
Merge branch 'main' into 8789-ephemeral
mtojek Aug 25, 2023
135b1e4
FIXMEs
mtojek Aug 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
FIXMEs
  • Loading branch information
@mtojek
mtojek committed Aug 25, 2023
commit 135b1e4f20baf81945a283f03c775b18008b56a1
7 changes: 3 additions & 4 deletions site/e2e/tests/restartWorkspace.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,9 @@ test("restart workspace with ephemeral parameters", async ({ page }) => {
true,
)

// FIXME: verify that build options are default (not selected).
// It is the opposite now until the site logic is corrected.
// Verify that build options are default (not selected).
await verifyParameters(page, workspaceName, richParameters, [
{ name: firstBuildOption.name, value: buildParameters[0].value },
{ name: secondBuildOption.name, value: buildParameters[1].value },
{ name: firstBuildOption.name, value: firstBuildOption.defaultValue },
{ name: secondBuildOption.name, value: secondBuildOption.defaultValue },
])
})
7 changes: 3 additions & 4 deletions site/e2e/tests/startWorkspace.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,9 @@ test("start workspace with ephemeral parameters", async ({ page }) => {
buildParameters,
)

// FIXME: verify that build options are default (not selected).
// It is the opposite now until the site logic is corrected.
// Verify that build options are default (not selected).
await verifyParameters(page, workspaceName, richParameters, [
{ name: firstBuildOption.name, value: buildParameters[0].value },
{ name: secondBuildOption.name, value: buildParameters[1].value },
{ name: firstBuildOption.name, value: firstBuildOption.defaultValue },
{ name: secondBuildOption.name, value: secondBuildOption.defaultValue },
])
})