feat(site): make workspace batch deletion GA #9313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpmct
reviewed
Aug 24, 2023
There was a problem hiding this comment.
Nice! We're making this an enterprise feature, right? If so, can you also update the enterprise docs: https://coder.com/docs/v2/latest/enterprise and add a basic section on the workspaces page?
|
@bpmct good call! |
|
Don't you think we should add other actions star/stop/restart/update before making it GA? Another issue is it can't delete failed workspaces and that is currently not possible from the dashboard. |
|
(just testing the deploy PR haha, not actually reviewing the functionality) |
aslilac
approved these changes
Aug 29, 2023
matifali
approved these changes
Aug 30, 2023
|
@matifali for me, it is always displayed, otherwise how could the user select the workspace? 🤔 |
|
Sorry, just ignore this. Thank you for showing me. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.