Skip to content

fix(cli): add --max-ttl to template create #9319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 25, 2023
Merged

fix(cli): add --max-ttl to template create #9319

merged 1 commit into from
Aug 25, 2023

Conversation

ammario
Copy link
Member

@ammario ammario commented Aug 24, 2023

fix(cli): add --max-ttl to template create

It was just in template edit by mistake.

It was just in template edit by mistake.
@ammario ammario linked an issue Aug 24, 2023 that may be closed by this pull request
@ammario ammario requested a review from mtojek August 24, 2023 22:34
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Although it would be perfect to have a unit test verifying the behavior.

@ammario
Copy link
Member Author

ammario commented Aug 25, 2023

I agree. I opted not to since the other TTL flags don't have tests and hopefully we do #9318 soon and all of this code is rewritten anyways.

@ammario ammario merged commit f149db6 into main Aug 25, 2023
@ammario ammario deleted the pr9319 branch August 25, 2023 16:00
@github-actions github-actions bot locked and limited conversation to collaborators Aug 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--max-ttl flag missing from coder templates create
2 participants