Skip to content

chore: assign soft ownership for xServices #932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2022

Conversation

greyscaled
Copy link
Contributor

No description provided.

@greyscaled greyscaled self-assigned this Apr 8, 2022
@codecov
Copy link

codecov bot commented Apr 8, 2022

Codecov Report

Merging #932 (7e4661c) into main (35a0acc) will decrease coverage by 0.17%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #932      +/-   ##
==========================================
- Coverage   66.00%   65.82%   -0.18%     
==========================================
  Files         228      228              
  Lines       14126    14126              
  Branches      105      105              
==========================================
- Hits         9324     9299      -25     
- Misses       3859     3879      +20     
- Partials      943      948       +5     
Flag Coverage Δ
unittest-go-macos-latest 53.36% <ø> (+0.14%) ⬆️
unittest-go-postgres- 65.78% <ø> (-0.11%) ⬇️
unittest-go-ubuntu-latest 55.72% <ø> (-0.02%) ⬇️
unittest-go-windows-2022 52.51% <ø> (-0.02%) ⬇️
unittest-js 58.25% <ø> (ø)
Impacted Files Coverage Δ
coderd/parameter/compute.go 74.07% <0.00%> (-4.45%) ⬇️
coderd/provisionerdaemons.go 59.52% <0.00%> (-4.05%) ⬇️
coderd/workspaceresources.go 59.34% <0.00%> (-1.63%) ⬇️
peer/channel.go 83.04% <0.00%> (-0.59%) ⬇️
peerbroker/proxy.go 57.55% <0.00%> (-0.59%) ⬇️
coderd/database/queries.sql.go 83.75% <0.00%> (-0.22%) ⬇️
peer/conn.go 81.97% <0.00%> (+0.25%) ⬆️
provisionerd/provisionerd.go 80.91% <0.00%> (+1.02%) ⬆️
provisioner/echo/serve.go 56.80% <0.00%> (+2.39%) ⬆️
provisionersdk/transport.go 85.10% <0.00%> (+6.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35a0acc...7e4661c. Read the comment docs.

@greyscaled greyscaled merged commit 0a2903c into main Apr 8, 2022
@greyscaled greyscaled deleted the vapurrmaid/xServices-codeowner branch April 8, 2022 19:17
@misskniss misskniss added this to the V2 Beta milestone May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants