chore: update aws_linux template #9325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the template with the following changes 1. use https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/ec2_instance_state.html to manage start/stop 2. Update agent metadata to use `coder stat` 3. Update some wrong regional flag emojis
bpmct
reviewed
Aug 25, 2023
There was a problem hiding this comment.
Hey, this looks good! Some feedback:
- Change
countof the agent to 0 or 1 based on the transition state so that the agent isn't flashing when the workspace is stopped
- Remove comment that mentions user data and just have local.user_data instead of conditionally rendering it
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the template with the following changes
ec2_instance_stateto manage start/stop.coder stat.Please test at https://dev.coder.com/templates/aws-linux.
Closes #8931