fix: fix coder template pull on Windows #9327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Spike Curtis <spike@coder.com>
|
Unfortunately, extracting the tests out of a |
Signed-off-by: Spike Curtis <spike@coder.com>
mafredri
approved these changes
Aug 25, 2023
Using the hide whitespace feature made it quite alright 👌 |
Signed-off-by: Spike Curtis <spike@coder.com>
johnstcn
approved these changes
Aug 25, 2023
|
Tested here seems to resolve the issue. PS C:\Users\matif\Downloads> .\coder_test.exe login https://pr9327.test.cdr.dev/
Your browser has been opened to visit:
https://pr9327.test.cdr.dev/cli-auth
> Paste your token here:
> Welcome to Coder, coder! You're authenticated.
PS C:\Users\matif\Downloads> .\coder_test.exe templates ls
NAME LAST UPDATED USED BY
kubernetes August 25, 2023 - active developers
PS C:\Users\matif\Downloads> .\coder_test.exe templates pull kubernetes
Extracting template to "kubernetes"
PS C:\Users\matif\Downloads> ls .\kubernetes\
Directory: C:\Users\matif\Downloads\kubernetes
Mode LastWriteTime Length Name
---- ------------- ------ ----
-a--- 25/08/2023 12:16 pm 2489 .terraform.lock.hcl
-a--- 25/08/2023 12:16 pm 8147 main.tf |
matifali
approved these changes
Aug 25, 2023
…-template-pull-windows
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #9291 and adds a unit test