Skip to content

fix: avoid derp-map updates endpoint leak #9390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 28, 2023
Merged

fix: avoid derp-map updates endpoint leak #9390

merged 2 commits into from
Aug 28, 2023

Conversation

deansheather
Copy link
Member

Uses websocketNetConn and makes sure we close nconn.Close() everywhere to cancel the context.

@deansheather deansheather enabled auto-merge (squash) August 28, 2023 17:27
@deansheather deansheather merged commit a2be2f9 into main Aug 28, 2023
@deansheather deansheather deleted the dean/fix-derp-map-updates-leak branch August 28, 2023 18:13
@github-actions github-actions bot locked and limited conversation to collaborators Aug 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mafredri mafredri mafredri approved these changes

+1 more reviewer

@coadler coadler coadler approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@deansheather deansheather

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deansheather @mafredri @coadler