Skip to content

chore: improve error message around gitaskpass failures #9407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 30, 2023
Merged

chore: improve error message around gitaskpass failures #9407

merged 1 commit into from
Aug 30, 2023

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented Aug 29, 2023

Closes #8905

@Emyrk Emyrk requested a review from matifali August 29, 2023 16:49
matifali
matifali approved these changes Aug 29, 2023
View reviewed changes
Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Emyrk Emyrk merged commit a910e93 into main Aug 30, 2023
@Emyrk Emyrk deleted the stevenmasley/gitaskpass_error branch August 30, 2023 13:58
@github-actions github-actions bot locked and limited conversation to collaborators Aug 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matifali matifali matifali approved these changes

Assignees

@Emyrk Emyrk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove user-facing error when gitauth regex does not match
2 participants
@Emyrk @matifali