feat(cli): add DataDog Go tracer #9411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coadler
approved these changes
Aug 29, 2023
coderd/tracing/exporter.go
Outdated
| if opts.DataDog { | ||
| // See more: | ||
| // https://docs.datadoghq.com/tracing/metrics/runtime_metrics/go/ | ||
| dd := ddotel.NewTracerProvider() |
There was a problem hiding this comment.
I think you need something like this to actually enable runtime metrics, according to your link
import ddtracer "gopkg.in/DataDog/dd-trace-go.v1/ddtrace/tracer"
dd := ddotel.NewTracerProvider(ddtracer.WithRuntimeMetrics())| @@ -24,7 +26,8 @@ type TracerOpts struct { | |||
| Default bool | |||
| // Coder exports traces to Coder's public tracing ingest service and is used | |||
| // to improve the product. It is disabled when opting out of telemetry. | |||
| Coder bool | |||
| Coder bool | |||
| DataDog bool | |||
|
@coadler - is there a place is datadog where the Go runtime information (e.g. goroutines) is already being reported? I couldn't find it. |
3111e6d to
3547b0e
Compare
|
Added the profiler as well. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(cli): add DataDog Go tracer