fix(enterprise/cli): correctly set default tags for PSK auth #9436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafredri
approved these changes
Aug 30, 2023
spikecurtis
requested changes
Aug 31, 2023
enterprise/cli/provisionerdaemons.go
Outdated
| @@ -83,6 +83,9 @@ func (r *RootCmd) provisionerDaemonStart() *clibase.Cmd { | |||
| }() | |||
|
|
|||
| logger := slog.Make(sloghuman.Sink(inv.Stderr)) | |||
| if ok, _ := inv.ParsedFlags().GetBool("verbose"); ok { | |||
| logger = logger.Leveled(slog.LevelDebug) | |||
| } | |||
spikecurtis
approved these changes
Sep 1, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #9235
fixes #9234
This PR fixes a bug in provisioner daemon authentication where a provisioner daemon run using
--psk=whateverwithout explicitly specifying--tag scope=organizationwould fail to pick up any jobs.Additionally, we were not respecting the global
CODER_VERBOSEvariable such that it was impossible to get debug logs from external provisioner daemons.I also sprinkled in a few more logging statements that helped me troubleshoot the issue.