test(site): improve E2E framework #9438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BrunoQuaresma Do you have an idea why is npm failing here? I can see occurrences like this: EDIT: Oh it looks like I forgot to commit this file... |
| @@ -554,7 +554,7 @@ jobs: | |||
| - run: pnpm playwright:install | |||
| working-directory: site | |||
|
|
|||
| - run: pnpm playwright:test | |||
| - run: pnpm playwright:test --workers 1 | |||
There was a problem hiding this comment.
Why are we setting workers to 1?
There was a problem hiding this comment.
If you delete this, playwright will run tests in parallel, and it may cause the Coder backend overloaded.
I want to reduce the amount of points that can break e2e tests. Additionally, our e2e tests are relatively quick, so if it isn't a problem I would disable parallelism for now.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds more debugging hooks to Chromium events, so that we can intercept HTTP calls, and simply log them.
Changes: