Skip to content

docs: add macOS installation page #9443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 30, 2023
Merged

docs: add macOS installation page #9443

merged 6 commits into from
Aug 30, 2023

Conversation

aslilac
Copy link
Member

@aslilac aslilac commented Aug 30, 2023

Screenshot 2023-08-30 at 12 44 52 PM

...which can tell people to use our cool newly-painted Homebrew tap!

I thought about mentioning the homebrew-core formula as well, but I'm not as sure how to discuss it in a way that makes it clear who each version is for.

@aslilac aslilac requested a review from matifali August 30, 2023 19:08
Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @bpmct can comment if we should mention the official homebrew formula.

For most people, it does not matter if they use our tap or homebrew formula, as they will use it only for clients.

Co-authored-by: Muhammad Atif Ali <atif@coder.com>
@@ -0,0 +1,35 @@
# macOS

You can use [Homebrew](https://brew.sh) to install the `coder` command. Homebrew
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this whole doc should go in the system packages section.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see both sides. I think it's nice to give macOS parity with Windows by giving users of them each an obvious page to look at.

@aslilac
Copy link
Member Author

aslilac commented Aug 30, 2023

Gonna merge as-is for now, we can tweak them in the future if need be

@aslilac aslilac merged commit d2462e5 into main Aug 30, 2023
@aslilac aslilac deleted the macos-install-docs branch August 30, 2023 20:37
@github-actions github-actions bot locked and limited conversation to collaborators Aug 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants