Skip to content

feat: implement agent process management #9461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Sep 15, 2023
Merged

feat: implement agent process management #9461

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
4ed4069
feat: implement agent process management
sreya Aug 30, 2023
7e59db6
improve process detection
sreya Aug 31, 2023
8c65216
add agentproc tests
sreya Aug 31, 2023
760cbb3
some minor agent tests
sreya Sep 1, 2023
f4b864e
add a proper test for proc management
sreya Sep 1, 2023
cbcb854
custom nice
sreya Sep 1, 2023
8230247
refactor into build files
sreya Sep 8, 2023
3e1defd
tick tock
sreya Sep 8, 2023
2fe9c70
make fmt
sreya Sep 8, 2023
ef41e9a
pr comments
sreya Sep 12, 2023
05baba0
lint
sreya Sep 12, 2023
478d57c
whoops
sreya Sep 12, 2023
0ced5ce
skip non-linux
sreya Sep 13, 2023
8aaa6d5
skip non-linux
sreya Sep 13, 2023
cea4851
prevent race
sreya Sep 13, 2023
5020eb4
only prioritize ourselves
sreya Sep 14, 2023
11ab047
Revert "only prioritize ourselves"
sreya Sep 14, 2023
46ef05a
only prioritize coder agent
sreya Sep 14, 2023
d132480
remove oom_score_adj
sreya Sep 14, 2023
04ee5cb
defer first
sreya Sep 15, 2023
ffbeab9
avoid resetting niceness for already niced procs
sreya Sep 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
prevent race
  • Loading branch information
@sreya
sreya committed Sep 13, 2023
commit cea4851769b71453a8cd471fe5c54ec51030d464
34 changes: 30 additions & 4 deletions agent/agent_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2525,14 +2525,21 @@ func TestAgent_ManageProcessPriority(t *testing.T) {
t.Skip("Skipping non-linux environment")
}

var buf bytes.Buffer
log := slog.Make(sloghuman.Sink(&buf)).Leveled(slog.LevelDebug)
var (
buf bytes.Buffer
wr = &syncWriter{
w: &buf,
}
)
log := slog.Make(sloghuman.Sink(wr)).Leveled(slog.LevelDebug)

_, _, _, _, _ = setupAgent(t, agentsdk.Manifest{}, 0, func(c *agenttest.Client, o *agent.Options) {
o.Logger = log
})

require.Eventually(t, func() bool {
wr.mu.Lock()
defer wr.mu.Unlock()
return strings.Contains(buf.String(), "process priority not enabled")
}, testutil.WaitLong, testutil.IntervalFast)
})
Expand All @@ -2544,8 +2551,13 @@ func TestAgent_ManageProcessPriority(t *testing.T) {
t.Skip("Skipping linux environment")
}

var buf bytes.Buffer
log := slog.Make(sloghuman.Sink(&buf)).Leveled(slog.LevelDebug)
var (
buf bytes.Buffer
wr = &syncWriter{
w: &buf,
}
)
log := slog.Make(sloghuman.Sink(wr)).Leveled(slog.LevelDebug)

_, _, _, _, _ = setupAgent(t, agentsdk.Manifest{}, 0, func(c *agenttest.Client, o *agent.Options) {
o.Logger = log
Expand All @@ -2554,6 +2566,9 @@ func TestAgent_ManageProcessPriority(t *testing.T) {
o.EnvironmentVariables = map[string]string{agent.EnvProcPrioMgmt: "1"}
})
require.Eventually(t, func() bool {
wr.mu.Lock()
defer wr.mu.Unlock()

return strings.Contains(buf.String(), "process priority not enabled")
}, testutil.WaitLong, testutil.IntervalFast)
})
Expand All @@ -2580,3 +2595,14 @@ func verifyCollectedMetrics(t *testing.T, expected []agentsdk.AgentMetric, actua
}
return true
}

type syncWriter struct {
mu sync.Mutex
w io.Writer
}

func (s *syncWriter) Write(p []byte) (int, error) {
s.mu.Lock()
defer s.mu.Unlock()
return s.w.Write(p)
}