Skip to content

test: improve E2E framework #9469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Sep 4, 2023
Merged

test: improve E2E framework #9469

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
65a3171
WIP
mtojek Aug 31, 2023
3cdff53
replace networkidle with domcontentloaded
mtojek Aug 31, 2023
f301c09
Merge branch 'main' into wip-e2e
mtojek Aug 31, 2023
fffe83a
stop workspaces
mtojek Aug 31, 2023
fd5850a
Use pkill
mtojek Sep 1, 2023
d486d23
enable pprof
mtojek Sep 1, 2023
564aab8
save pprof
mtojek Sep 1, 2023
5935bf6
Merge branch 'main' into wip-e2e
mtojek Sep 1, 2023
2f4626c
Merge branch 'main' into wip-e2e
mtojek Sep 4, 2023
e81432f
Constants
mtojek Sep 4, 2023
ca061d4
comments
mtojek Sep 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
enable pprof
  • Loading branch information
@mtojek
mtojek committed Sep 1, 2023
commit d486d237a781d3231f968be3743dd798e8c35199
4 changes: 2 additions & 2 deletions site/e2e/helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,8 +339,8 @@ export const startAgentWithCommand = async (
return cp
}

export const stopAgent = async (cp: ChildProcess) => {
exec(`pkill -P ${cp.pid}`, (error) => {
export const stopAgent = async (cp: ChildProcess, goRun: boolean = true) => {
exec(goRun ? `pkill -P ${cp.pid}` : `kill ${cp.pid}`, (error) => {
if (error) {
throw new Error(`exec error: ${JSON.stringify(error)}`)
}
Expand Down
3 changes: 2 additions & 1 deletion site/e2e/playwright.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,8 @@ export default defineConfig({
`--dangerous-disable-rate-limits ` +
`--provisioner-daemons 10 ` +
`--provisioner-daemons-echo ` +
`--provisioner-daemon-poll-interval 50ms`,
`--provisioner-daemon-poll-interval 50ms ` +
`--pprof-enable`,
env: {
...process.env,

Expand Down
2 changes: 1 addition & 1 deletion site/e2e/tests/outdatedAgent.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,5 +56,5 @@ test("ssh with agent " + agentVersion, async ({ page }) => {
})

await stopWorkspace(page, workspaceName)
await stopAgent(agent)
await stopAgent(agent, false)
})