Skip to content

refactor(coderd/database): split Time and Now into dbtime package #9482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 1, 2023

Conversation

mafredri
Copy link
Member

@mafredri mafredri commented Sep 1, 2023

Ref: #9380

The database.Now is used almost across the whole application, but usually we don't care about importing the actual database when we do.

No change in size (yet).

❯ make build/coder-slim_linux_amd64
/home/coder/src/coder/coder/build/coder-slim_2.1.4-devel+dfce60add_linux_amd64

❯ ls -lha /home/coder/src/coder/coder/build/coder-slim_2.1.4-devel+dfce60add_linux_amd64
-rwxr-xr-x 2 coder coder 70M Sep  1 12:05 /home/coder/src/coder/coder/build/coder-slim_2.1.4-devel+dfce60add_linux_amd64*

@mafredri mafredri requested review from Emyrk and kylecarbs and removed request for Emyrk September 1, 2023 12:06
mafredri added a commit that referenced this pull request Sep 1, 2023
@mafredri mafredri enabled auto-merge (squash) September 1, 2023 16:45
@mafredri mafredri merged commit 19d7da3 into main Sep 1, 2023
@mafredri mafredri deleted the mafredri/refactor-database-time branch September 1, 2023 16:50
@github-actions github-actions bot locked and limited conversation to collaborators Sep 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants