Skip to content

refactor(cli): remove scaletest from slim binary #9485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

refactor(cli): remove scaletest from slim binary #9485

wants to merge 1 commit into from

Conversation

mafredri
Copy link
Member

@mafredri mafredri commented Sep 1, 2023

This change removes 3 MB when combined with #9483.

Ref: #9380, #9483

❯ ls -lha build
total 2.3G
drwxr-xr-x  2 coder coder 4.0K Sep  1 13:23 ./
drwxr-xr-x 30 coder coder 4.0K Sep  1 13:19 ../
-rw-r--r--  1 coder coder 366M Sep  1 13:21 coder-slim_2.1.4-devel+2089ddad8.tar
-rw-r--r--  1 coder coder  99M Sep  1 13:21 coder-slim_2.1.4-devel+2089ddad8.tar.zst
-rw-r--r--  1 coder coder  434 Sep  1 13:21 coder-slim_2.1.4-devel+2089ddad8_checksums.sha1
-rwxr-xr-x  1 coder coder  53M Sep  1 13:20 coder-slim_2.1.4-devel+2089ddad8_darwin_amd64*
-rwxr-xr-x  1 coder coder  53M Sep  1 13:20 coder-slim_2.1.4-devel+2089ddad8_darwin_arm64*
-rwxr-xr-x  1 coder coder  57M Sep  1 13:20 coder-slim_2.1.4-devel+2089ddad8_linux_amd64*
-rwxr-xr-x  1 coder coder  55M Sep  1 13:20 coder-slim_2.1.4-devel+2089ddad8_linux_arm64*
-rwxr-xr-x  1 coder coder  54M Sep  1 13:20 coder-slim_2.1.4-devel+2089ddad8_linux_armv7*
-rwxr-xr-x  1 coder coder  49M Sep  1 13:21 coder-slim_2.1.4-devel+2089ddad8_windows_amd64.exe*
-rwxr-xr-x  1 coder coder  47M Sep  1 13:21 coder-slim_2.1.4-devel+2089ddad8_windows_arm64.exe*
-rwxr-xr-x  1 coder coder 218M Sep  1 13:22 coder_2.1.4-devel+2089ddad8_darwin_amd64*
-rwxr-xr-x  1 coder coder 219M Sep  1 13:22 coder_2.1.4-devel+2089ddad8_darwin_arm64*
-rwxr-xr-x  1 coder coder 220M Sep  1 13:21 coder_2.1.4-devel+2089ddad8_linux_amd64*
-rwxr-xr-x  1 coder coder 216M Sep  1 13:21 coder_2.1.4-devel+2089ddad8_linux_arm64*
-rwxr-xr-x  1 coder coder 215M Sep  1 13:22 coder_2.1.4-devel+2089ddad8_linux_armv7*
-rwxr-xr-x  1 coder coder 212M Sep  1 13:22 coder_2.1.4-devel+2089ddad8_windows_amd64.exe*
-rwxr-xr-x  1 coder coder 209M Sep  1 13:23 coder_2.1.4-devel+2089ddad8_windows_arm64.exe*

@mafredri mafredri self-assigned this Sep 1, 2023
@mafredri mafredri requested a review from kylecarbs September 1, 2023 13:25
@mafredri mafredri force-pushed the mafredri/refactor-scaletest branch 2 times, most recently from a02bebd to 7e27734 Compare September 1, 2023 13:42
johnstcn
johnstcn requested changes Sep 1, 2023
View reviewed changes
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break the current scaletest workflow, as it uses the slim binary.

If the problem is that scaletest imports from coderd, we can instead move or copy those deps.

@mafredri
Copy link
Member Author

mafredri commented Sep 1, 2023 •
edited
Loading

Holding off on this PR as slim scaletest is in use by the scale test suite. Perphaps we can modify the coderd/tracing import instead.

Edit: Logically I feel scaletesting doesn't belong in the slim binary, but the convenience is obvious.

Edit 2: It seems that simply eliminating the coderd/tracing import reduces the size with 2MB instead of 3MB, so that was the main win in removing the scaletest command.

@mafredri
refactor(cli): remove scaletest from slim binary
1bc2e5c 
This change removes 3 MB when combined with #9483.

Ref: #9380, #9483
@mafredri mafredri force-pushed the mafredri/refactor-scaletest branch from 7e27734 to 1bc2e5c Compare September 4, 2023 16:48
@mafredri mafredri marked this pull request as draft September 4, 2023 16:49
@mafredri mafredri mentioned this pull request Sep 4, 2023
Closed
@github-actions github-actions bot added the stale This issue is like stale bread. label Sep 12, 2023
@github-actions github-actions bot closed this Sep 15, 2023
@github-actions github-actions bot deleted the mafredri/refactor-scaletest branch March 5, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnstcn johnstcn johnstcn requested changes

@kylecarbs kylecarbs kylecarbs approved these changes

Assignees

@mafredri mafredri

Labels
stale This issue is like stale bread.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mafredri @johnstcn @kylecarbs