Skip to content

chore: add ts_omit_aws tag to remove aws dependency pulled in by tailscale #9486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 1, 2023
Merged

chore: add ts_omit_aws tag to remove aws dependency pulled in by tailscale #9486

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions scripts/build_go.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,10 +99,12 @@ ldflags=(
-X "'github.com/coder/coder/v2/buildinfo.tag=$version'"
)

# We use ts_omit_aws here because on Linux it prevents Tailscale from importing
# github.com/aws/aws-sdk-go-v2/aws, which adds 7 MB to the binary.
if [[ "$slim" == 0 ]]; then
build_args+=(-tags embed)
build_args+=(-tags "embed,ts_omit_aws")
else
build_args+=(-tags slim)
build_args+=(-tags "slim,ts_omit_aws")
fi
if [[ "$agpl" == 1 ]]; then
# We don't use a tag to control AGPL because we don't want code to depend on
Expand Down