Skip to content

fix(site): fix workspace parameters update when having immutable parameters #9500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 4, 2023
Merged

fix(site): fix workspace parameters update when having immutable parameters #9500

merged 2 commits into from
Sep 4, 2023
+39 −21

Conversation

BrunoQuaresma
Copy link
Collaborator

Fix #9499

@BrunoQuaresma BrunoQuaresma self-assigned this Sep 4, 2023
cdr-bot[bot]
cdr-bot bot approved these changes Sep 4, 2023
View reviewed changes
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

matifali
matifali reviewed Sep 4, 2023
View reviewed changes
Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it solves the issue. Fine for me. But you may wait for Marcin Tojek to review the code changes and approach.

@BrunoQuaresma
Copy link
Collaborator Author

BrunoQuaresma commented Sep 4, 2023 •
edited
Loading

@matifali my only problem is this be released with the issue.

@matifali matifali self-requested a review September 4, 2023 00:54
@BrunoQuaresma BrunoQuaresma merged commit b9f604c into main Sep 4, 2023
@BrunoQuaresma BrunoQuaresma deleted the bq/fix-ws-parameters-update branch September 4, 2023 00:56
@github-actions github-actions bot locked and limited conversation to collaborators Sep 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matifali matifali matifali approved these changes

@cdr-bot cdr-bot[bot] cdr-bot[bot] approved these changes

@mtojek mtojek Awaiting requested review from mtojek

Assignees

@BrunoQuaresma BrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can not update a mutable parameter of a workspace
2 participants
@BrunoQuaresma @matifali