Skip to content

docs: add CODER_TLS_ADDRESS to documentation for TLS setup #9503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 5, 2023
Merged

docs: add CODER_TLS_ADDRESS to documentation for TLS setup #9503

merged 8 commits into from
Sep 5, 2023

Conversation

voxnyx
Copy link
Contributor

@voxnyx voxnyx commented Sep 4, 2023

Updated TLS instructions to include CODER_TLS_ADDRESS

@voxnyx
Update configure.md
647215b 
Updated TLS instructions to include CODER_TLS_ADDRESS
@cdr-bot cdr-bot bot added the community Pull Requests and issues created by the community. label Sep 4, 2023
@github-actions
Copy link

github-actions bot commented Sep 4, 2023 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@voxnyx
Copy link
Contributor Author

voxnyx commented Sep 4, 2023

I have read the CLA Document and I hereby sign the CLA

cdrcommunity added a commit to coder/cla that referenced this pull request Sep 4, 2023
@cdrcommunity
@RaineAllDay has signed the CLA in coder/coder#9503
23c0758
@matifali matifali changed the title Add CODER_TLS_ADDRESS to documentation for TLS Setup. docs: add CODER_TLS_ADDRESS to documentation for TLS setup Sep 4, 2023
@matifali
Copy link
Member

matifali commented Sep 4, 2023

@RaineAllDay Thanks for the contribution.

matifali
matifali reviewed Sep 4, 2023
View reviewed changes
ericpaulsen
ericpaulsen previously requested changes Sep 4, 2023
View reviewed changes
@matifali matifali requested a review from ericpaulsen September 5, 2023 09:12
matifali
matifali approved these changes Sep 5, 2023
View reviewed changes
Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @ericpaulsen can you give another look. I changed all references to 127.0.0.1 with 0.0.0.0 and linked to our reverse proxy docs at the bottom.

@matifali
Copy link
Member

matifali commented Sep 5, 2023

@bpmct and @ericpaulsen thoughts on moving https://github.com/RaineAllDay/coder/tree/main/examples/web-server to docs/admin directory?

@matifali matifali added the docs Area: coder.com/docs label Sep 5, 2023
bpmct
bpmct previously requested changes Sep 5, 2023
View reviewed changes
Copy link
Member

@bpmct bpmct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! However, I believe we already link to this in our configure docs. https://coder.com/docs/v2/latest/admin/configure#tls--reverse-proxy.

Also I noticed a typo: revres and the link goes to your personal repo not the Coder official one.

@bpmct
Copy link
Member

bpmct commented Sep 5, 2023 •
edited
Loading

@bpmct and @ericpaulsen thoughts on moving https://github.com/coder/coder/tree/main/examples/web-server to docs/admin directory?

I would be open to this, but I think the main thing is we link to these from our official docs, just like example templates.

@matifali matifali requested a review from bpmct September 5, 2023 13:35
@matifali
Copy link
Member

matifali commented Sep 5, 2023

@bpmct The OP only suggested to mention CODER_TLS_ADDRESS. I did the rest of the refactoring. Thanks for pointing out the that docs url was pointing to OP's fork. It is fixed now.

@matifali matifali enabled auto-merge (squash) September 5, 2023 13:59
@matifali matifali disabled auto-merge September 5, 2023 13:59
@matifali matifali dismissed stale reviews from bpmct and ericpaulsen September 5, 2023 19:05

outdated

@matifali matifali enabled auto-merge (squash) September 5, 2023 19:06
@matifali matifali merged commit d85c354 into coder:main Sep 5, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Sep 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matifali matifali matifali approved these changes

@ericpaulsen ericpaulsen Awaiting requested review from ericpaulsen

@bpmct bpmct Awaiting requested review from bpmct

Assignees

@voxnyx voxnyx

Labels
community Pull Requests and issues created by the community. docs Area: coder.com/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@voxnyx @matifali @bpmct @ericpaulsen