refactor(coderd/schedule): move cron schedule to cron package #9507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes an indirect import of `coderd/database` from the CLI and results in a logical separation between server related and generalized schedule. No size change (yet). Ref: #9380
johnstcn
approved these changes
Sep 4, 2023
@johnstcn Do you mean it will lead to confusion reading the code? I could realias the import 🤔. Or do you have any suggestion for an alternate package name (in our repo)? |
Up to you! I don't have any constructive suggestions here but I don't consider this a blocker to merge. |
johnstcn
approved these changes
Sep 4, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes an indirect import of
coderd/databasefrom the CLI andresults in a logical separation between server related and generalized
schedule.
No size change (yet).
Ref: #9380
Not sure about the deep nesting into
coderd, I'm open to moving this package elsewhere, perhaps top-level?