refactor(examples): pre-parse frontmatter via scripts/examplegen #9514
+373
−94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes 2 MB from the slim binary. Ref: #9380
mtojek
approved these changes
Sep 4, 2023
There was a problem hiding this comment.
That's a nice improvement 👍
I'm also not sold on both calling this file .json and adding the generated by header since this will look like invalid JSON, open to suggestions.
I had a discussion with a fronted engineer some time ago who claimed that JSON comments are VERY normal in the "JavaScript world" :) I guess that we can leave it as is or remove the header comment (pity).
f1f56b5 to
b3a3e3b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes 2 MB from the slim binary.
Ref: #9380
This is a proposal. We could decide that these 2 MB are not worth it, or we could look at more light-weight parsing of the frontmatter. This is a trade-off since generating the metadata will add complexity to our pipeline.
I'm also not sold on both calling this file
.jsonand adding the generated by header since this will look like invalid JSON, open to suggestions.