fix(cli/dotfiles): add an exception for .gitconfig
#9515
Conversation
There was a problem hiding this comment.
I understand what prompted this change, but I think we need to make some changes. The .gitconfig does not have any special meaning inside a Git repository, so we can totally link it. However, we definitely shouldn't link .gitignore or .gitattributes files. These have special meaning to the actual repository being worked on and if a user has these in their dotfiles, we can't know for sure what their intent is, so linking is unsafe.
Imagine a dotfiles .gitignore file that ignores almost everything. Now it gets linked as global ignore and suddenly the files in all repositories are unattainable (or seem clean).
It might be a better idea for users to store their files in e.g. .config/git/config, .config/git/ignore, etc.
|
Thank you, @mafredri, for the detailed insights. I guess it's a very corner case with how people use dotfiles. So it's better if we close this for now. Should we close the issue as not planned, too? |
|
@matifali I think we can change this to only be an exception for |
.gitconfig
Resolves #8306