refactor(coderd/database): generate dbresetpw with queries for reset-password command #9519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As the reset-password command requires direct database access to work, I would not expect the Coder database to be accessible from places where the slim CLI is being run, so I'm not sure this is the best approach here. Removing the reset-password command from the slim CLI would technically be a breaking change, but it is unlikely to make a difference outside of running Coder locally. |
|
Closing as removing the subcommand is preferred 👍🏻 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes 1 MB from the slim binary, and combined with the
following PRs: #9481, #9506, #9508, #9517, a total of 4 MB.
Ref: #9380
See alternative approach: #9520