Skip to content

refactor(site): update versions table design #9540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 6, 2023
Merged

refactor(site): update versions table design #9540

merged 2 commits into from
Sep 6, 2023

Conversation

aslilac
Copy link
Member

@aslilac aslilac commented Sep 6, 2023 •
edited
Loading

Screenshot 2023-09-05 at 6 14 12 PM Screenshot 2023-09-05 at 6 12 43 PM
  • get rid of redundant usage of the word "version"
  • add a badge for the most recent version
  • show a disabled "promote" button for the active version for vertical consistency

Just a couple minor things that make the page look a lot nicer imo

BrunoQuaresma
BrunoQuaresma approved these changes Sep 6, 2023
View reviewed changes
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aslilac aslilac merged commit 75139d1 into main Sep 6, 2023
@aslilac aslilac deleted the template-versions-ui-cleanup branch September 6, 2023 14:31
@github-actions github-actions bot locked and limited conversation to collaborators Sep 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrunoQuaresma BrunoQuaresma BrunoQuaresma approved these changes

Assignees

@aslilac aslilac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aslilac @BrunoQuaresma