chore(site): refactor stories and tests from components directory #9578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
BrunoQuaresma
commented
Sep 7, 2023
- Migrate stories to use non-deprecated Storybook v7 API
- Remove render tests from the integration tests layer
- Remove unnecessary or duplicated stories
mtojek
approved these changes
Sep 7, 2023
| @@ -48,14 +39,14 @@ const useStyles = makeStyles<Theme, styleProps>((theme) => ({ | |||
| display: props.inline ? "inline-flex" : "flex", | |||
| flexDirection: "row", | |||
| alignItems: "center", | |||
| background: props.inline ? "rgb(0 0 0 / 30%)" : "hsl(223, 27%, 3%)", | |||
| border: props.inline ? undefined : `1px solid ${theme.palette.divider}`, | |||
| background: "rgb(0 0 0 / 30%)", | |||
There was a problem hiding this comment.
just double-checking: is it intended? hsl(223, 27%, 3%) disappeared.
| args: { | ||
| resource: { | ||
| ...MockWorkspaceResource, | ||
| type: "noexistentvalue", |
There was a problem hiding this comment.
nit: notexistingvalue or nonexisting
BrunoQuaresma
commented
Sep 7, 2023
| color: theme.palette.primary.contrastText, | ||
| fontFamily: MONOSPACE_FONT_FAMILY, | ||
| fontSize: 14, | ||
| borderRadius: theme.shape.borderRadius, | ||
| padding: theme.spacing(1), | ||
| lineHeight: "150%", | ||
| border: `1px solid ${theme.palette.divider}`, |
There was a problem hiding this comment.
@mtojek it was added here
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.