Skip to content

fix: remove tf provider versions in examples/ #9586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

ericpaulsen
Copy link
Member

@ericpaulsen ericpaulsen commented Sep 7, 2023

this PR removes the static terraform provider versions in our example templates, allowing for Terraform to pull the latest version by default.

a customer asked to bump our our provider version in the envbox template, so I figured I'd remove the versions entirely to prevent our examples from going out-of-date. this also removes the update_template_versions.sh file as it is no longer needed (it also did not keep the versions up-to-date, as intended).

@ericpaulsen ericpaulsen changed the title fix: rm tf provider versions in examples/ fix: remove tf provider versions in examples/ Sep 7, 2023
@ericpaulsen ericpaulsen enabled auto-merge (squash) September 7, 2023 18:37
@ericpaulsen ericpaulsen merged commit ccda1c5 into main Sep 7, 2023
@ericpaulsen ericpaulsen deleted the rm-provider-versions branch September 7, 2023 18:53
@github-actions github-actions bot locked and limited conversation to collaborators Sep 7, 2023
@matifali
Copy link
Member

matifali commented Sep 7, 2023

We have to be careful as future major versions may break templates. Maybe its time we do coder/templates#9.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants