-
Notifications
You must be signed in to change notification settings - Fork 887
feat: add envFrom value to Helm chart #9587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
w.r.t the CODER_ACCESS_URL being automatically set, you could just put that behind a new value too like coder.useClusterAccessURL
or something
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a test that uses this with a new golden file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I contributed so I won't approve
this PR adds support for the
coder.envFrom
value to the Helm chart. this will allow for Coder's environment variables to be passed from a single secret.i'm pushing this in draft mode, because there is one caveat; the
$hasAccessURL
variable cannot identify ifCODER_ACCESS_URL
is set in the secret, so it will always default to the cluster-internal URL unless the access URL is specified using the traditionalcoder.env
variable.ideally, we parse the vars from the secret and pass them into the existing
containers.env
section in the template, but I have not gotten this to work. something akin to: