Skip to content

fix(scripts): wget terraform directly from releases.hashicorp.com #9594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 8, 2023

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented Sep 8, 2023

No description provided.

@johnstcn johnstcn changed the title wget terraform directly from releases.hashicorp.com fix(scripts): wget terraform directly from releases.hashicorp.com Sep 8, 2023
Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I? 😀

Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this 👍

@@ -25,6 +22,16 @@ RUN apk add --no-cache \
-u 1000 \
-G coder \
coder
# Terraform was disabled in the edge repo due to a build issue.
# https://gitlab.alpinelinux.org/alpine/aports/-/commit/f3e263d94cfac02d594bef83790c280e045eba35
# Using wget for now. Note that busybox unzip doesn't support streaming.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It used to 😢

busybox unzip /tmp/terraform.zip -d / && \
mv /terraform /usr/local/bin/terraform && \
rm -f /tmp/terraform.zip && \
chmod +x /usr/local/bin/terraform && \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it already is +x inside the zip, but caution doesn't hurt here.

@johnstcn johnstcn enabled auto-merge (squash) September 8, 2023 09:56
@johnstcn johnstcn merged commit fb3616c into main Sep 8, 2023
@johnstcn johnstcn deleted the cj/docker-base-terraform-fix branch September 8, 2023 10:02
@github-actions github-actions bot locked and limited conversation to collaborators Sep 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants