Skip to content

refactor: generate application URL on backend side #9618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Sep 12, 2023
Merged

refactor: generate application URL on backend side #9618

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
d726fab
WIP
mtojek Sep 11, 2023
96d8f59
Merge branch 'main' into 8145-url-from-backend
mtojek Sep 11, 2023
ec977f2
make gen
mtojek Sep 11, 2023
e914801
convertApps
mtojek Sep 11, 2023
55d7ff1
storybook
mtojek Sep 11, 2023
f56dbe3
storybook
mtojek Sep 11, 2023
826ef76
use app url
mtojek Sep 11, 2023
d998238
make fmt
mtojek Sep 11, 2023
41459dd
test
mtojek Sep 12, 2023
fdc1845
Merge branch 'main' into 8145-url-from-backend
mtojek Sep 12, 2023
74d9dbe
fix
mtojek Sep 12, 2023
b0b2c33
fix
mtojek Sep 12, 2023
da4ddde
WIP
mtojek Sep 12, 2023
fea0af3
unit tests
mtojek Sep 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use app url
  • Loading branch information
@mtojek
mtojek committed Sep 11, 2023
commit 826ef7603f32dbcdb757cf7979c262e663cfb045
50 changes: 23 additions & 27 deletions coderd/workspaceagents.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1324,35 +1324,31 @@ func convertProvisionedApps(dbApps []database.WorkspaceApp) []codersdk.Workspace
func convertApps(dbApps []database.WorkspaceApp, agent database.WorkspaceAgent, owner database.User, workspace database.Workspace) []codersdk.WorkspaceApp {
apps := make([]codersdk.WorkspaceApp, 0)
for _, dbApp := range dbApps {
/*
let appSlug = app.slug;
let appDisplayName = app.display_name;
if (!appSlug) {
appSlug = appDisplayName;
}
if (!appDisplayName) {
appDisplayName = appSlug;
}



if (appsHost && app.subdomain) {
const subdomain = `${appSlug}--${agent.name}--${workspace.name}--${username}`;
href = `${window.location.protocol}//${appsHost}/`.replace("*", subdomain);
}

*/
var subdomainName string
if dbApp.Subdomain && agent.Name != "" && owner.Username != "" && workspace.Name != "" {
var appSlug = dbApp.Slug
if appSlug == "" {
appSlug = dbApp.DisplayName
}
subdomainName = httpapi.ApplicationURL{
AppSlugOrPort: appSlug,
AgentName: agent.Name,
WorkspaceName: workspace.Name,
Username: owner.Username,
}.String()
}

apps = append(apps, codersdk.WorkspaceApp{
ID: dbApp.ID,
URL: dbApp.Url.String,
External: dbApp.External,
Slug: dbApp.Slug,
DisplayName: dbApp.DisplayName,
Command: dbApp.Command.String,
Icon: dbApp.Icon,
Subdomain: dbApp.Subdomain,
SharingLevel: codersdk.WorkspaceAppSharingLevel(dbApp.SharingLevel),
ID: dbApp.ID,
URL: dbApp.Url.String,
External: dbApp.External,
Slug: dbApp.Slug,
DisplayName: dbApp.DisplayName,
Command: dbApp.Command.String,
Icon: dbApp.Icon,
Subdomain: dbApp.Subdomain,
SubdomainName: subdomainName,
SharingLevel: codersdk.WorkspaceAppSharingLevel(dbApp.SharingLevel),
Healthcheck: codersdk.Healthcheck{
URL: dbApp.HealthcheckUrl,
Interval: dbApp.HealthcheckInterval,
Expand Down