Skip to content

feat: add template_id and template_name to workspace data source #9655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 13, 2023
Merged

feat: add template_id and template_name to workspace data source #9655

merged 2 commits into from
Sep 13, 2023

Conversation

sreya
Copy link
Collaborator

@sreya sreya commented Sep 13, 2023 •
edited
Loading

This PR adds the plumbing necessary to inject the template ID and name into the workspace data source.

fixes #9149

@sreya sreya requested a review from mtojek September 13, 2023 00:53
mtojek
mtojek approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In terms of feature completeness, it is 👍

I don't see the need to expose template_id if we have template_name exposed. Wouldn't it be more convenient to expose template_version?

@sreya
Copy link
Collaborator Author

sreya commented Sep 13, 2023

@mtojek I'm guessing id is useful because it is immutable whereas you can update the name of a template. I could see template_version being useful but I'd like to wait for a use-case to surface before implementing it.

@sreya sreya merged commit 3dc1e22 into main Sep 13, 2023
@sreya sreya deleted the jon/templateid branch September 13, 2023 16:09
@github-actions github-actions bot locked and limited conversation to collaborators Sep 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

@mtojek mtojek mtojek approved these changes

Assignees

@sreya sreya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose template name and ID via a Terraform data source
3 participants
@sreya @kylecarbs @mtojek