feat(coderd/database): generate foreign key constraints and add database.IsForeignKeyViolation #9657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….IsForeignKeyViolation
johnstcn
commented
Sep 13, 2023
There was a problem hiding this comment.
note: I haven't performed any DRY refactoring on this piece here; I figure de-duplication is premature.
mtojek
approved these changes
Sep 13, 2023
spikecurtis
reviewed
Sep 13, 2023
| name := "" | ||
| switch { | ||
| case strings.Contains(query, "ALTER TABLE") && strings.Contains(query, "ADD CONSTRAINT"): | ||
| name = strings.Split(query, " ")[6] |
There was a problem hiding this comment.
parsing is pretty flimsy, but I guess the rest of the file is no better...
There was a problem hiding this comment.
Yeah... it works for the moment.
There was a problem hiding this comment.
I don't think it's worth improving, SQL is pretty stable 😄.
mafredri
reviewed
Sep 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw that we were generating this for unique constraints and thought it might be useful to add it for foreign keys as well (to be used in a follow-up PR)