Skip to content

feat: add Acquirer to provisionerdserver pkg #9658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 13, 2023

Conversation

spikecurtis
Copy link
Contributor

relates to #9428

In the interest of keeping code review managable, this first PR introduces the Acquirer but does not integrate it into the provisionerd server. A follow on PR will integrate it.

Signed-off-by: Spike Curtis <spike@coder.com>
@spikecurtis spikecurtis self-assigned this Sep 13, 2023
@spikecurtis spikecurtis changed the title chore: add Acquirer to provisionerdserver pkg feat: add Acquirer to provisionerdserver pkg Sep 13, 2023
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall, some comments below.

Signed-off-by: Spike Curtis <spike@coder.com>
@spikecurtis spikecurtis merged commit 4ebf490 into main Sep 13, 2023
@spikecurtis spikecurtis deleted the spike/9428-refactor-acquire-job branch September 13, 2023 12:36
@github-actions github-actions bot locked and limited conversation to collaborators Sep 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants