fix(scaletest/workspacetraffic): wait for non-zero metrics before cancelling in TestRun #9663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtojek
approved these changes
Sep 13, 2023
| require.NoError(t, runner.Run(ctx, "", &logs), "unexpected error calling Run()") | ||
|
|
||
| gotMetrics := make(chan struct{}) | ||
| go func() { |
There was a problem hiding this comment.
nit: I'm always confused if there is a possibility of a routine leak. defer goes first then routine is killed, right?
There was a problem hiding this comment.
Defer runs when the surrounding function returns. So assert.Eventually() has to finish before gotMetrics is closed, and <-gotMetrics will block until that happens. Then we cancel the context passed to runner.Run, which will cause it to exit, then we close runDone, which unblocked <-runDone.
I think goleak would have caught a goroutine leak here as well.
mafredri
approved these changes
Sep 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully fixes #9661