Skip to content

chore: print page content on failed promise #9681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 14, 2023
Merged

chore: print page content on failed promise #9681

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b8ceaaf
chore: print page content on failed promise
mtojek Sep 14, 2023
8d4e64c
WIP
mtojek Sep 14, 2023
3ce891d
Short timeout
mtojek Sep 14, 2023
0de6249
use terminal
mtojek Sep 14, 2023
7ff41d4
use less generic phrase
mtojek Sep 14, 2023
413de1e
fmt
mtojek Sep 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions site/e2e/tests/webTerminal.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,18 +41,30 @@ test("web terminal", async ({ context, page }) => {
const terminal = await pagePromise;
await terminal.waitForLoadState("domcontentloaded");

const xtermRows = await terminal.waitForSelector("div.xterm-rows", {
await terminal.waitForSelector("div.xterm-rows", {
state: "visible",
});

// Ensure that we can type in it
await terminal.keyboard.type("echo he${justabreak}llo");
await terminal.keyboard.type("echo he${justabreak}llo123456");
await terminal.keyboard.press("Enter");

// Check if "echo" command was executed
await xtermRows.waitForSelector('div:text-matches("hello")', {
state: "visible",
});
// try-catch is used temporarily to find the root cause: https://github.com/coder/coder/actions/runs/6176958762/job/16767089943
try {
await terminal.waitForSelector(
'div.xterm-rows div:text-matches("hello123456")',
{
state: "visible",
timeout: 10 * 1000,
},
);
} catch (error) {
const pageContent = await terminal.content();
// eslint-disable-next-line no-console -- Let's see what is inside of xterm-rows
console.log("Unable to find echoed text:", pageContent);
throw error;
}

await stopAgent(agent);
});