Skip to content

ci: upgrade runners #9689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2023
Merged

ci: upgrade runners #9689

merged 1 commit into from
Sep 15, 2023

Conversation

ammario
Copy link
Member

@ammario ammario commented Sep 15, 2023

ci: upgrade runners

Per DataDog, I've doubled the resources given to our bottlenecked jobs.

@ammario
Copy link
Member Author

ammario commented Sep 15, 2023

image

Per DataDog, I've doubled the resources given to our bottlenecked jobs.
@ammario ammario changed the title ci: upgrade Windows runners ci: upgrade runners Sep 15, 2023
@ammario ammario added the hotfix label Sep 15, 2023
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@ammario ammario merged commit 281faf9 into main Sep 15, 2023
@ammario ammario deleted the pr9689 branch September 15, 2023 01:20
@github-actions github-actions bot locked and limited conversation to collaborators Sep 15, 2023
@@ -387,7 +387,7 @@ jobs:

deploy:
name: "deploy"
runs-on: ${{ github.repository_owner == 'coder' && 'buildjet-8vcpu-ubuntu-2204' || 'ubuntu-latest' }}
runs-on: ${{ github.repository_owner == 'coder' && 'buildjet-16vcpu-ubuntu-2204' || 'ubuntu-latest' }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems kinda moot since deploy only runs on main and it doesn't matter that much how long it takes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My thinking is if it’s well parallelized then it costs the same to give it more resources.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants