Skip to content

chore(site): refactor starter templates to use react-query #9697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 18, 2023

Conversation

BrunoQuaresma
Copy link
Collaborator

No description provided.

@BrunoQuaresma BrunoQuaresma requested a review from a team September 15, 2023 12:45
@BrunoQuaresma BrunoQuaresma self-assigned this Sep 15, 2023
@BrunoQuaresma BrunoQuaresma requested review from code-asher and removed request for a team September 15, 2023 12:45
Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I like how this simplifies the story mocks, too. Love the commits too.

exampleId,
},
});
const templateExamplesQuery = useQuery(templateExamples(organizationId));
Copy link
Member

@code-asher code-asher Sep 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not something to do in this PR, but just a note that maybe we need a way to get a template example by ID, seems unfortunate to query all the templates just to get one!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do agree with you!

@BrunoQuaresma BrunoQuaresma merged commit e74d8a7 into main Sep 18, 2023
@BrunoQuaresma BrunoQuaresma deleted the bq/refactor-starter-templates-service branch September 18, 2023 14:02
@github-actions github-actions bot locked and limited conversation to collaborators Sep 18, 2023
@BrunoQuaresma
Copy link
Collaborator Author

Related to #9598

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants