Skip to content

fix: prevent workspace search bar text from getting garbled #9703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Sep 15, 2023
Merged

fix: prevent workspace search bar text from getting garbled #9703

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
32ebe81
chore: Reorganize hook calls for useWorkspacesFilter
Parkreiner Sep 13, 2023
92006aa
refactor: Clean up some filter logic
Parkreiner Sep 13, 2023
8d10578
refactor: Create debounce utility hooks
Parkreiner Sep 14, 2023
913f944
Merge branch 'main' into filter-fix
Parkreiner Sep 14, 2023
fec4384
docs: Clean up comments for clarity
Parkreiner Sep 14, 2023
2d4d285
fix: Update focus logic to apply for any inner focus
Parkreiner Sep 14, 2023
11c06e1
fix: Add onBlur behavior for state syncs
Parkreiner Sep 15, 2023
551780c
chore: Add progress for debounce test
Parkreiner Sep 15, 2023
3d028a7
chore: Finish tests for debounce hooks
Parkreiner Sep 15, 2023
9ea0e1a
Merge branch 'main' into filter-fix
Parkreiner Sep 15, 2023
83c6022
docs: Add file description and warning
Parkreiner Sep 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
docs: Clean up comments for clarity
  • Loading branch information
@Parkreiner
Parkreiner committed Sep 14, 2023
commit fec4384a86935d96e3a4a2ffb7c79801a07d70d3
11 changes: 5 additions & 6 deletions site/src/hooks/debounce.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,22 +17,18 @@ type useDebouncedFunctionReturn<Args extends unknown[]> = Readonly<{
*
* If the debounce time changes while a callback has been queued to fire, the
* callback will be canceled completely. You will need to restart the debounce
* process by calling debounced again.
* process by calling the returned-out function again.
*/
export function useDebouncedFunction<
// Parameterizing on the args instead of the whole callback function type to
// avoid type contra-variance issues; want to avoid need for type assertions
// avoid type contra-variance issues
Args extends unknown[] = unknown[],
>(
callback: (...args: Args) => void | Promise<void>,
debounceTimeMs: number,
): useDebouncedFunctionReturn<Args> {
const timeoutIdRef = useRef<number | null>(null);
const cancelDebounce = useCallback(() => {
// Clearing timeout because, even though hot-swapping the timeout value
// while keeping any active debounced functions running was possible, it
// seemed like it'd be ripe for bugs. Can redesign the logic if that ends up
// becoming an actual need down the line.
if (timeoutIdRef.current !== null) {
window.clearTimeout(timeoutIdRef.current);
}
Expand Down Expand Up @@ -69,6 +65,9 @@ export function useDebouncedFunction<
return { debounced, cancelDebounce } as const;
}

/**
* Takes any value, and returns out a debounced version of it.
*/
export function useDebouncedValue<T = unknown>(
value: T,
debounceTimeMs: number,
Expand Down