feat(coderd/database/dbtestutil): add ability to dump database on failure #9704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d06e9c1 to
1c4bf16
Compare
mafredri
approved these changes
Sep 18, 2023
coderd/database/dbtestutil/db.go
Outdated
| return | ||
| } | ||
| snakeCaseName := regexp.MustCompile("[^a-zA-Z0-9-_]+").ReplaceAllString(t.Name(), "_") | ||
| outPath := filepath.Join(cwd, snakeCaseName+".test.sql") |
There was a problem hiding this comment.
How about adding a random suffix to make sure we don't overwrite previous dumps?
There was a problem hiding this comment.
Could add YYYYmmddHHMMSS so you know at a glance which one is the most recent?
mtojek
approved these changes
Sep 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
72dff7f included a provision to dump the contents of the database on failure, which actually seems really useful in a generic context.
dbtestutil.t.Logbut this is also an option if running in CI. We just need to make sure to not leak any secrets.