Skip to content

feat: show update messages on workspace page #9705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 15, 2023
Merged

feat: show update messages on workspace page #9705

merged 4 commits into from
Sep 15, 2023

Conversation

aslilac
Copy link
Member

@aslilac aslilac commented Sep 15, 2023 •
edited
Loading

Part of #8657

Screenshot 2023-09-15 at 11 54 34 AM Screenshot 2023-09-15 at 12 18 24 PM
  • Get rid of the ignore-able warnings
  • Refactor some existing message loading stuff
  • Show an update alert when a workspace is outdated
  • Show the update message in the update dialog
  • Start adding … to ui elements which require further confirmation/action

@aslilac
Copy link
Member Author

aslilac commented Sep 15, 2023 •
edited
Loading

@BrunoQuaresma there are separate tests for the non-ignored versions of these flows, which remain in place. we're only removing tests for functionality that is being removed.

BrunoQuaresma
BrunoQuaresma approved these changes Sep 15, 2023
View reviewed changes
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall good improvement, I will leave the suggestions up to you.

@aslilac aslilac mentioned this pull request Sep 15, 2023
Closed
5 tasks
@aslilac aslilac merged commit 9e053ce into main Sep 15, 2023
@aslilac aslilac deleted the workspace-update-messages branch September 15, 2023 19:09
@github-actions github-actions bot locked and limited conversation to collaborators Sep 15, 2023
@aslilac aslilac linked an issue Sep 22, 2023 that may be closed by this pull request
Add template version messages to the rest of the product #8657
Closed
5 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrunoQuaresma BrunoQuaresma BrunoQuaresma approved these changes

Assignees

@aslilac aslilac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add template version messages to the rest of the product
2 participants
@aslilac @BrunoQuaresma